Skip to content

Fix multiple code quality issues identified in review #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
karydenroberts wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix multiple code quality issues identified in review #19

karydenroberts wants to merge 1 commit into from

Conversation

@karydenroberts
Copy link

@karydenroberts karydenroberts commented Dec 12, 2025

  • Add missing BedrockError exception class in llm.py
  • Remove debug time.sleep() calls (2s in llm.py, 20s in operate.py)
  • Fix QueryParam.mode default value to match Literal type hint
  • Replace Chinese debug messages with English equivalents
  • Add sensible placeholder values with comments in v1_test.py
  • Add setup.py for proper package installation via pip install -e .

@claude
Fix multiple code quality issues identified in review
548d7d4 
- Add missing BedrockError exception class in llm.py
- Remove debug time.sleep() calls (2s in llm.py, 20s in operate.py)
- Fix QueryParam.mode default value to match Literal type hint
- Replace Chinese debug messages with English equivalents
- Add sensible placeholder values with comments in v1_test.py
- Add setup.py for proper package installation via pip install -e .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karydenroberts @claude